Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put CI script into shell script #890

Merged
merged 2 commits into from
Sep 29, 2016
Merged

Conversation

markuspf
Copy link
Member

This PR puts the code run for CI into a script rather than the travis config file.

  • scripting in the travis YAML file is ugly, error prone, and a pain to debug,
  • we can now use this script for AppVeyor as well
  • with sufficient tweaking this can be run locally to test whether it works before pushing to travis and having to wait for results to come back.

@markuspf markuspf force-pushed the refactor-ci branch 2 times, most recently from 356244b to 82d0d9b Compare August 19, 2016 16:27
@fingolfin
Copy link
Member

Sounds like a good idea. Though, I wonder, the script refrences TRAVIS_OS_NAME, does that work correctly on AppVeyor?

BTW, AppVeyor builds always seem to fail right now, this is very annoying...

@markuspf
Copy link
Member Author

AppVeyor fails because there is no AppVeyor config in master. That is reasonably easily fixed.

The CI script is not perfect yet, I should probably try and find out what to do about these environment variables.

@codecov-io
Copy link

Current coverage is 49.53% (diff: 100%)

Merging #890 into master will increase coverage by 0.21%

@@             master       #890   diff @@
==========================================
  Files           422        423      +1   
  Lines        228398     232037   +3639   
  Methods        3448       3448           
  Messages          0          0           
  Branches          0          0           
==========================================
+ Hits         112663     114950   +2287   
- Misses       115735     117087   +1352   
  Partials          0          0           

Powered by Codecov. Last update da0416e...f07ab00

@fingolfin
Copy link
Member

The travis test had failed, but I rerun it, and now all tests seem to have passed.

So is this ready to be merged? Or perhaps there were changes to the CI integration in the meantime which need to be adapted first?

@markuspf
Copy link
Member Author

I think it is ready to be merged, subject to further improvements which would come with the renovation of the tests (#790 and friends)

@fingolfin fingolfin merged commit 940739e into gap-system:master Sep 29, 2016
@markuspf markuspf deleted the refactor-ci branch February 5, 2017 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants