Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements for LatticeByCyclicExtension #905

Merged
merged 5 commits into from
Oct 7, 2016

Commits on Sep 27, 2016

  1. Fix LatticeByCyclicExtension when second arg is a list

    According to the documentation of LatticeByCyclicExtension, the optional
    second argument can be either a function, or a list of two functions.
    The latter did not actually work, which is now fixed.
    fingolfin committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    85ea9d3 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2016

  1. Install methods for computing size of cyclic groups

    These are based on the assumption that computing the order
    of a group element cannot be harder than computing the size
    of the group, and in general is faster
    fingolfin committed Sep 28, 2016
    Configuration menu
    Copy the full SHA
    c3c9f86 View commit details
    Browse the repository at this point in the history
  2. Make Zuppos(G,func) faster

    This variant of Zuppos is currently undocumented, but used internally by
    LatticeByCyclicExtension. This change speeds it as follows:
    
    1. If Zuppos(G) is already known, it is faster to simply filter that list.
    2. It replaces Group(c) by Subgroup(G,[c]), which makes things faster if
       G is a IsHandledByNiceMonomorphism group (such as an automorphism group).
    3. In addition, it only creates this subgroup once (not twice as before),
       which can lead to further improvements.
    fingolfin committed Sep 28, 2016
    Configuration menu
    Copy the full SHA
    815e3cb View commit details
    Browse the repository at this point in the history
  3. Replace instances of Size(g)=1 by IsTrivial(g)

    Note that there are immediate methods which set IsTrivial suitably as
    soon as the Size is known, hence these changes do not break any existing
    use case. However, there are examples where computing Size is
    infeasible, but computing IsTrivial is possible, sometimes even trivial.
    fingolfin committed Sep 28, 2016
    Configuration menu
    Copy the full SHA
    d139d03 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d3f5e45 View commit details
    Browse the repository at this point in the history