ENHANCE: Option NoPrecomputedData to avoid use of data libraries
#986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulpke
added
the
do not merge
Current coverage is 49.45% (diff: 73.21%)@@ master #986 diff @@
==========================================
Files 424 424
Lines 223224 223260 +36
Methods 3430 3430
Messages 0 0
Branches 0 0
==========================================
- Hits 110418 110409 -9
- Misses 112806 112851 +45
Partials 0 0
|
|
Seems plausible to me. |
|
Some of these commits are already in master. Maybe an accidental merge happened instead of a rebase? |
|
@hungaborhorvath This is only supposed to be merged after recent changes in |
hulpke
force-pushed
the
datalib
branch
2 times, most recently
from
7106bc6
to
074bfdf
Compare
and how to check/turn it off. This might need to be moved to a more prominent place.
hulpke
removed
the
do not merge
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tick all what applies to this pull request
Write below the description of changes (for the release notes)
Add the function option
NoPrecomputedDatato turn off reliance on data libraries. This applies for all uses of Small groups/Tom/Prim/Trans data libraries in the main GAP library.Added deocumentation in section on data libraries.