Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #1125
what
Manage undo/redo state for
<MdInput/>
component (the comment input box) inside of react and bind hotkeys.why
Using a controlled react input component only preserves native undo/redo functionality when the component is updated with the
onChange
event handler from the controlled component itself.Adding more advanced features like
requires manualing updating the state which in turn wipes out the native undo/redo functionality.
how
hotkeyListener
utility to bind new undo/redo functionality over the native key bindings and prevent defaultsChecklist:
(PS: i took this simple PR template from testing-library/react-testing-library)