Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from erlang:master #214

Merged
merged 23 commits into from
Feb 12, 2025
Merged

[pull] master from erlang:master #214

merged 23 commits into from
Feb 12, 2025

Conversation

pull[bot]
Copy link

@pull pull bot commented Feb 12, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Update several libraries to fix bugs and inconsistencies, and improve compatibility. Update documentation to reflect the changes.

Bug Fixes:

  • Disable an unsafe runtime optimization in binary construction that caused silent memory corruption.
  • Fix a couple of bugs that could make global's internal state inconsistent when a connection was reconnected.
  • Fix type specs for ssh:connection_info/1,2 functions to include {error, term()} return value.
  • Fix ssh client to accept a banner sent during processing keyboard interactive user authentication.
  • Fix large sftp transfers that hang due to redundant window adjustment requests.
  • Fix common test crashing when running tests with OTP-26 and earlier, while having previous test results from OTP-27.

Enhancements:

  • Consider keyCertSign to be compatible with extended key usage for TLS client/server auth in CAs, adhering to widespread implementations.
  • Clarify that each segment specification Ei in a bit string construction is a value whose default type is integer.

Erlang/OTP and others added 23 commits February 6, 2025 17:26
…OTP-19388' into maint-25

* kuba/maint-25/ssh/fix_connection_info_spec/ERIERL-1165/OTP-19388:
  ssh: fix connection_info result typespec
… maint-25

* alexandrejbr/ssh-accept-userauth-banner/OTP-19392:
  ssh: avoid protocol error on userauth banner
…arlier_for_maint26_and_25/ERIERL-1166/OTP-19385' into maint-25

* michal/common_test/fix_compatiblity_between_otp27_and_earlier_for_maint26_and_25/ERIERL-1166/OTP-19385:
  Don't crash when test summary contains more values than we want
…to maint-25

* kuba/maint-25/ssh/sftp_large_transfer_fix/OTP-19435:
  ssh: remove adjust_window call from ssh_connection
…t-25

* rickard/global-restart-connect-fix/OTP-19381:
  [kernel] global: Fix restart of connect after double init_connect
  [kernel] global: Fix cleanup prior to restart of connect
…1177/OTP-19462' into maint-25

* john/erts/disable-unsafe-bs_append-optimization/ERIERL-1177/OTP-19462:
  erts: Disable unsafe optimization in bs_append
…into maint-26

* ingela/maint-26/public_key/ext-key-usage-ca/OTP-19240:
  public_key: Adjust certificate key usage compatible check
…t-26

* rickard/global-restart-connect-fix/OTP-19381:
  [kernel] global: Fix restart of connect after double init_connect
  [kernel] global: Fix cleanup prior to restart of connect
…6' into maint-26

* john/erts/disable-unsafe-bs_append-optimization/merge-26:
  erts: Disable unsafe optimization in bs_append
* maint-26:
  Updated OTP version
  Prepare release
  Update copyright year
* maint:
  Updated OTP version
  Prepare release
  Update copyright year
…wording' into maint

* Olivier-Boudeville/doc/improve-bitstring-default-match-wording:
  Respect hard word-wrap at column 80
  Clarify default type of matched values in bit strings
* maint-25:
  Updated OTP version
  Prepare release
  Update copyright year
* maint:
  Updated OTP version
  Prepare release
  Update copyright year
@pull pull bot added the ⤵️ pull label Feb 12, 2025
Copy link

sourcery-ai bot commented Feb 12, 2025

Reviewer's Guide by Sourcery

This pull request updates the documentation release notes across multiple components by adding new sections that describe fixed bugs and improvements. The changes target ERTS, Kernel, SSH, Common_Test, and Public_Key release notes, as well as clarifying content in the reference manual.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added new ERTS release notes sections detailing a critical runtime optimization fix.
  • Introduced an 'Erts 14.2.5.7' section to document the disabling of an unsafe runtime optimization in binary construction.
  • Introduced an 'Erts 13.2.2.13' section with the same runtime optimization fix for legacy version tracking.
erts/doc/notes.md
Added new Kernel release notes sections addressing global state consistency bugs.
  • Added a 'Kernel 9.2.4.6' section to fix issues where the global state could become inconsistent upon reconnection.
  • Added a 'Kernel 8.5.4.4' section with a similar fix for previous versions.
lib/kernel/doc/notes.md
Enhanced SSH release notes with new sections for multiple bug fixes.
  • Created 'Ssh 4.15.3.9' section specifying a fix to include an error term in the type specs for ssh:connection_info/1,2 functions.
  • Updated SSH client behavior to accept banners during keyboard interactive authentication.
  • Addressed issues with large sftp transfers hanging by preventing redundant window adjustment requests.
lib/ssh/doc/notes.md
Updated Common_Test release notes to improve test stability across OTP versions.
  • Added 'Common_Test 1.24.0.6' section to ensure tests with OTP-26 and earlier do not crash when previous test results from OTP-27 are present.
lib/common_test/doc/notes.md
Introduced a new Public_Key release note section to enhance compatibility.
  • Added 'Public_Key 1.15.1.5' section to address keyCertSign compatibility with extended key usage for TLS client/server authentication.
lib/public_key/doc/notes.md
Clarified type specification documentation in the reference manual.
  • Revised the expressions.md to specify that each segment value defaults to an 'integer' type before the optional size expression and type specifier list.
system/doc/reference_manual/expressions.md
Updated otp_versions.table file.
  • Touched the otp_versions.table file to reflect associated changes with the updated documentation.
otp_versions.table

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@pull pull bot merged commit 53e6751 into garazdawi:master Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants