Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Issue 58 #59

Merged
merged 6 commits into from
Oct 26, 2019
Merged

Issue 58 #59

merged 6 commits into from
Oct 26, 2019

Conversation

garciparedes
Copy link
Owner

@garciparedes garciparedes commented Oct 26, 2019

PR Details

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New release

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

* Minor performance improvements pre checking if list is empty before computing max. #53
* Now StatelessCrosser.iterator is a cached_property.
* Improved "LongestTimePlannedTripCriterion" and "ShortestTimePlannedTripCriterion". #58
@codecov
Copy link

codecov bot commented Oct 26, 2019

Codecov Report

Merging #59 into master will increase coverage by 0.76%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   91.99%   92.76%   +0.76%     
==========================================
  Files          64       64              
  Lines        1849     1851       +2     
==========================================
+ Hits         1701     1717      +16     
+ Misses        148      134      -14
Impacted Files Coverage Δ
jinete/algorithms/utils/crossers/stateless.py 88.88% <100%> (+38.88%) ⬆️
jinete/models/stops.py 97.36% <100%> (+0.14%) ⬆️
jinete/models/trips.py 98.03% <100%> (+0.03%) ⬆️
jinete/models/planned_trips.py 92.42% <100%> (ø) ⬆️
jinete/models/criterions.py 86% <100%> (ø) ⬆️
jinete/models/positions.py 97.29% <0%> (+2.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfda593...933d0e5. Read the comment docs.

@garciparedes garciparedes merged commit e2de58d into master Oct 26, 2019
@garciparedes garciparedes deleted the issue-58 branch October 26, 2019 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant