Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow controlling log level with env variable #452

Closed
edvald opened this issue Jan 10, 2019 · 2 comments
Closed

Allow controlling log level with env variable #452

edvald opened this issue Jan 10, 2019 · 2 comments
Assignees
@eysi09
Labels
enhancement

Comments

@edvald
Copy link
Collaborator

edvald commented Jan 10, 2019

This would be especially helpful when running/debugging tests, but also potentially for CI and general day-to-day development and debugging.

I'd suggest changing LogLevel from an enum to a union type along the way.
@drubin
Copy link
Contributor

drubin commented Jan 10, 2019

I think this also fits in with #309

@eysi09 eysi09 self-assigned this Jan 10, 2019
eysi09 added a commit that referenced this issue Jan 29, 2019
@eysi09
feat(logger): allow controlling level with env var (#452)
ec8bd45
edvald added a commit that referenced this issue Jan 29, 2019
@edvald
Merge pull request #494 from garden-io/logger-fixes
8a21abc 
Logger fixes (closes #493 and #452)
@eysi09
Copy link
Collaborator

eysi09 commented Jan 30, 2019

Closed in #494

@eysi09 eysi09 closed this as completed Jan 30, 2019
@snyk-bot snyk-bot mentioned this issue May 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eysi09 eysi09

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@edvald @drubin @eysi09