fix(core): fix to dependency logic in dev command #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, if a service was deployed with hot reloading via the dev command, and a test spec had a runtime dependency on that service, the service would initially be deployed without hot reloading enabled. This would result in subsequent hot reloads for that service failing. Also added a test case checking for this behavior.
edvald
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Before this fix, if a service was deployed with hot reloading via the dev command, and a test spec had a runtime dependency on that service, the service would initially be deployed without hot reloading enabled.
This would result in subsequent hot reloads for that service failing.
Also added a test case checking for this behavior.