fix(k8s): include value files in default Helm include clause #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
approved these changes
Feb 24, 2020
10ko
force-pushed
the
add-default-includes-helm
branch
from
fe88385 to
e21b939
Compare
edvald
force-pushed
the
add-default-includes-helm
branch
from
e21b939 to
e1ad8a8
Compare
|
I amended to also include explicitly set |
edvald
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When using the
helmmodule type if the user doesn't specify any value in theinclude:[]field we don't automatically include anyvalues.yamlthat are needed for the chart.Which issue(s) this PR fixes:
Fixes a request from our community channel.
Special notes for your reviewer: