chore: switch from yarn to npm #3919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walther
force-pushed
the
0.13-npm
branch
2 times, most recently
from
ee54738 to
ae273a9
Compare
* chore: move away from k8s javascript client fork The changes in the fork have been released. We can move away from the fork. This enables NPM migration. * ci: make sure to use fresh cache when yarn.lock changes This is to avoid running into caching issues * fix: pin down version to 0.18.0 We had to pin the version to 0.18.0 because with 0.18.1 we ran into a problem due to kubernetes client's migration from execa to child_process.spawnSync, see also kubernetes-client/javascript#1013
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 1514254 | Generic High Entropy Secret | 0f48820 | core/src/constants.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
Closing this as stale, but this PR contains potentially-useful information for the next attempt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Work in progress.
TODO:
npm installworksnpm run devworksType 'V' is not assignable to type 'KubernetesObject'gdev deployworksError: Patch file found for package pkg which is not present at node_modules/pkg