Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: garden publish deploymentImageId for container actions #4797

Closed
wants to merge 1 commit into from

Conversation

Walther
Copy link
Contributor

@Walther Walther commented Jul 11, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #4796

Special notes for your reviewer:

WIP attempt, do not merge yet


EDIT: not the right fix, I was mistakenly looking at the wrong place: this would only affect the container provider (TIL!), which we rarely use (e.g. here for circleci-runner etc). (Sidenote: the container provider is probably currently also unable to publish anywhere other than dockerhub? Unsure if it warrants more investigation / possible fix.)

The actual issue is in the publish method of the kubernetes provider as before, core/src/plugins/kubernetes/container/publish.ts, or in the implementation of action.getOutput("deploymentImageId").

Notably, after #4740 we do take into account the deploymentRegistry, but if you are only using the publishId field, it does not appear to get used the right way.

@Walther Walther closed this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

garden publish does not respect user-defined publishId
1 participant