fix: garden publish deploymentImageId for container actions #4797
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4796
Special notes for your reviewer:
WIP attempt, do not merge yet
EDIT: not the right fix, I was mistakenly looking at the wrong place: this would only affect the
container
provider (TIL!), which we rarely use (e.g. here for circleci-runner etc). (Sidenote: thecontainer
provider is probably currently also unable to publish anywhere other than dockerhub? Unsure if it warrants more investigation / possible fix.)The actual issue is in the
publish
method of thekubernetes
provider as before,core/src/plugins/kubernetes/container/publish.ts
, or in the implementation ofaction.getOutput("deploymentImageId")
.Notably, after #4740 we do take into account the
deploymentRegistry
, but if you are only using thepublishId
field, it does not appear to get used the right way.