-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: NPM registry package for garden
#5087
base: main
Are you sure you want to change the base?
Changes from all commits
ef90b92
dc3ba15
1a5267e
87999b0
edce41d
d70e5b2
a038ed0
b6a2196
e111e12
2e899ba
c53806a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
static |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,23 @@ | ||
#!/usr/bin/env node | ||
#!/usr/bin/env node --max-old-space-size=4096 --max-semi-space-size=64 | ||
const path = require('path'); | ||
|
||
process.env.STATIC_DIR = path.join(__dirname, '..', 'static'); | ||
|
||
const fs = require('fs'); | ||
const exec = require('child_process').exec; | ||
|
||
const gitDir = path.join(process.env.STATIC_DIR, '.git'); | ||
|
||
if (!fs.existsSync(gitDir)) { | ||
exec(`git init ${process.env.STATIC_DIR}`, (error, stdout, stderr) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @stefreak, where would you move this call? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should finalize and merge #5120 before merging this, so we don't have to call it at all. |
||
if (error) { | ||
console.error(`Error: ${error.message}`); | ||
} | ||
if (stderr) { | ||
console.error(`Stderr: ${stderr}`); | ||
} | ||
}); | ||
} | ||
|
||
if (process.env.GARDEN_ENABLE_PROFILING === "1" || process.env.GARDEN_ENABLE_PROFILING === "true") { | ||
// Patch require to profile module loading | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
{ | ||
"$schema": "node_modules/lerna/schemas/lerna-schema.json", | ||
"version": "0.13.13", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will this version get updated correctly with every release publishing step? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What I mean is, does this number here get updated and committed back or is this just a placeholder of sorts? |
||
"npmClient": "yarn", | ||
"packages": [ | ||
"cli", | ||
"core", | ||
"plugins/conftest", | ||
"plugins/conftest-container", | ||
"plugins/conftest-kubernetes", | ||
"plugins/jib", | ||
"plugins/pulumi", | ||
"plugins/terraform", | ||
"sdk" | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
*.ts |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
*.ts |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
*.ts |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
*.ts |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"arrowParens": "always", | ||
"printWidth": 120, | ||
"quoteProps": "consistent", | ||
"semi": false, | ||
"trailingComma": "es5", | ||
"tabWidth": 2 | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
*.ts |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
*.ts |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"arrowParens": "always", | ||
"printWidth": 120, | ||
"quoteProps": "consistent", | ||
"semi": false, | ||
"trailingComma": "es5", | ||
"tabWidth": 2 | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add some documentation how exactly the process works that increments the package version to the correct version number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TimBeyer sure! In a code comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could leave a few short comments in here and then more detailed in https://github.com/garden-io/garden/blob/main/RELEASE_PROCESS.md