-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace unzipper to resolve corrupt binaries on node > v18.15 #5161
Conversation
Example, from few months back, of the failing CI step due to corrupt binaries issue before we downgraded to node v18.15. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great. Should we also load pkg
from github so that it uses the newest pgk-fetch
version and updates the CLI node version then?
@TimBeyer We could, my only concern is about the stability if |
We also should pin it to a specific commit and then revisit that every once in a while. |
How about this approach and overriding the |
Actually let's try this instead: vercel/pkg#1998 (comment) |
Haha exactly |
Package overrides are somehow fundamentally broken in |
902843d
to
f414b8e
Compare
|
f414b8e
to
2002154
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some test failures, please check.
This has been superseded by #5233 (We had to cherry-pick due to Node update in the ESM PR) |
What this PR does / why we need it:
Replaces
unzipper
withunzip-stream
due to upstream issue ZJONSSON/node-unzipper#271 not being fixed yet. And that was blocking us from updating our node version from v18.15.Replaced with
unzip-stream
as the api is almost the same and it does resolve the issue.Also a step forward for #4158
Which issue(s) this PR fixes:
Fixes #4467
#4467 was previously fixed by pinning the node version to 18.15.
Special notes for your reviewer:
I built and published the runner image to dockerhub already and the CI uses the new image for this PR.
Also looked into the yauzl as that seems to be most popular package for dealing with zip files however yauzl doesn't support streams.
Please also test it by running and using
garden util fetch-tools
.