fix(helm): disable --atomic by default in Helm modules
#5968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
force-pushed
the
fix/helm-module-disable-default-atomic
branch
2 times, most recently
from
28679c5 to
311855f
Compare
To align the behaviour with the Helm deploy action.
vvagaytsev
force-pushed
the
fix/helm-module-disable-default-atomic
branch
from
311855f to
aa8d704
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Aligns the default value of the
--atomicflag in Helm module- and deploy action configs, and sets the default value tofalse.Which issue(s) this PR fixes:
Fixes #2713
Special notes for your reviewer: