fix(core): emit namespaceStatus events during provider init #6759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, `namespaceStatus` events weren't actually being emitted during provider resolution, since the event bus on the plugin context hadn't been set up to pipe `namespaceStatus` events to the main event bus (this happened later in the flow). This is the probable cause for some users experiencing dangling namespaces that weren't being cleared up by Cloud's automatic environment cleanup when module/action resolution failed (since the namespace status events that would usually be emitted by the "get status" and "deploy" handlers for those actions weren't being emitted). This still needs to be verified, but most likely fixes the issue. This was fixed by setting up the event forwarding during the initialization of the plugin event bus.
10ko
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was fixed by setting up the event forwarding during the initialization of the plugin event bus.
What this PR does / why we need it:
Before this fix,
namespaceStatusevents weren't actually being emitted during provider resolution, since the event bus on the plugin context hadn't been set up to pipenamespaceStatusevents to the main event bus (this happened later in the flow).This is the probable cause for some users experiencing dangling namespaces that weren't being cleared up by Cloud's automatic environment cleanup when module/action resolution failed (since the namespace status events that would usually be emitted by the "get status" and "deploy" handlers for those actions weren't being emitted). This still needs to be verified, but most likely fixes the issue.