fix(k8s): skip setMinikubeDockerEnv when vm-driver=None #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-kpyc
force-pushed
the
kpyc/fix-minikube-driver-none
branch
from
e16be89 to
a655dd2
Compare
|
Thanks @dev-kpyc! Looks good. integ tests are failing for unrelated reasons btw, seems to be for all external contributors. |
edvald
previously approved these changes
Jun 30, 2019
|
Oops, spoke too soon. This will actually fail if you start minikube without a |
dev-kpyc
force-pushed
the
kpyc/fix-minikube-driver-none
branch
2 times, most recently
from
8ffbe81 to
336fa6e
Compare
dev-kpyc
force-pushed
the
kpyc/fix-minikube-driver-none
branch
from
336fa6e to
0825c5a
Compare
edvald
approved these changes
Jul 4, 2019
|
Looks good @dev-kpyc. The integ test failures are unrelated to this. I'll do a quick manual check and then merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#907