ocm command and some ctf cmd extension #59

mandelsoft · 2021-12-17T15:11:08Z

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

jschicktanz · 2022-01-12T09:14:27Z

pkg/commands/componentarchive/get/get.go

+	"github.com/gardener/component-cli/pkg/logger"
+)
+
+// Options defines the options that are used to add resources to a component descriptor


Docstring seems misleading to me

jschicktanz · 2022-01-12T09:16:13Z

cmd/ocm/main.go

+func main() {
+	ctx := context.Background()
+	defer ctx.Done()
+	cmd := app.NewComponentsCliCommand(ctx)


Should we also rename the function from NewComponentsCliCommand() to NewOCMCliCommand() ?

jschicktanz · 2022-01-12T09:19:55Z

pkg/commands/componentarchive/get/get.go

+	Property string
+}
+
+// NewGetCommand creates a command to add additional resources to a component descriptor.


Docstring seems misleading to me

jschicktanz · 2022-01-12T09:20:44Z

pkg/commands/componentarchive/get/get.go

+	cmd := &cobra.Command{
+		Use:   "get COMPONENT_ARCHIVE_PATH [options...]",
+		Args:  cobra.MinimumNArgs(1),
+		Short: "set some component descriptor properties",


Doc seems misleading to me

jschicktanz · 2022-01-12T09:21:17Z

pkg/commands/componentarchive/get/get.go

+		Args:  cobra.MinimumNArgs(1),
+		Short: "set some component descriptor properties",
+		Long: `
+the set command sets some component descriptor properies like the component name and/or version.


Doc seems misleading to me

jschicktanz · 2022-01-12T09:38:16Z

pkg/commands/componentarchive/set/set_test.go

+
+func TestConfig(t *testing.T) {
+	RegisterFailHandler(Fail)
+	RunSpecs(t, "Resources Test Suite")


Suggested change

RunSpecs(t, "Resources Test Suite")

RunSpecs(t, "Component Archive Set Test Suite")

jschicktanz · 2022-01-12T09:38:46Z

pkg/commands/componentarchive/get/get_test.go

+	RunSpecs(t, "Resources Test Suite")
+}
+
+var _ = Describe("Set", func() {


Suggested change

var _ = Describe("Set", func() {

var _ = Describe("Get", func() {

jschicktanz · 2022-01-12T09:45:12Z

pkg/commands/ctf/push.go

 type PushOptions struct {
-	// CTFPath is the path to the directory containing the ctf archive.
-	CTFPath string
+	// CTFPaths is the path to the directory containing the ctf archive.


Suggested change

// CTFPaths is the path to the directory containing the ctf archive.

// CTFPaths is the list of paths to the directories containing the ctf archives.

jschicktanz · 2022-01-12T09:49:30Z

pkg/commands/ctf/push.go

-		Args:  cobra.ExactArgs(1),
+		Use:   "push <CTF_PATH> ...",
+		Args:  cobra.MinimumNArgs(1),
 		Short: "Pushes all archives of a ctf to a remote repository",


Suggested change

Short: "Pushes all archives of a ctf to a remote repository",

Short: "Pushes one or more ctf archives to a remote repository",

jschicktanz · 2022-01-12T09:50:31Z

pkg/commands/ctf/push.go

+		Args:  cobra.MinimumNArgs(1),
 		Short: "Pushes all archives of a ctf to a remote repository",
 		Long: `
 Push pushes all component archives and oci artifacts to the defined oci repository.


Suggested change

Push pushes all component archives and oci artifacts to the defined oci repository.

Push pushes one or more ctf archives (including all component archives and oci artifacts) to a remote repository.

mandelsoft requested a review from a team as a code owner December 17, 2021 15:11

mandelsoft requested review from Diaphteiros and reshnm December 17, 2021 15:11

gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Dec 17, 2021

ocm command and some ctf cmd extension

4ff44b4

mandelsoft force-pushed the work branch from c73b6c2 to 4ff44b4 Compare December 22, 2021 11:11

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 22, 2021

gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 22, 2021

gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jan 10, 2022

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 10, 2022

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 10, 2022

mandelsoft force-pushed the work branch from d9204c4 to 29b173d Compare January 10, 2022 12:01

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 10, 2022

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 10, 2022

mandelsoft force-pushed the work branch from 29b173d to 4ed7c7e Compare January 10, 2022 12:12

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 10, 2022

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 10, 2022

mandelsoft force-pushed the work branch from 4ed7c7e to d454b7d Compare January 10, 2022 14:07

gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) and removed size/l Size of pull request is large (see gardener-robot robot/bots/size.py) labels Jan 10, 2022

gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 10, 2022

mandelsoft force-pushed the work branch from d454b7d to 41bb384 Compare January 10, 2022 16:41

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 10, 2022

gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 10, 2022

add set command to modify comp desc

a57b19d

mandelsoft force-pushed the work branch from 41bb384 to a57b19d Compare January 11, 2022 09:34

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 11, 2022

gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 11, 2022

jschicktanz suggested changes Jan 12, 2022

View reviewed changes

gardener-robot added the needs/changes Needs (more) changes label Jan 12, 2022

gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Jul 12, 2022

gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jan 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ocm command and some ctf cmd extension #59

ocm command and some ctf cmd extension #59

Uh oh!

mandelsoft commented Dec 17, 2021

Uh oh!

jschicktanz Jan 12, 2022

Uh oh!

jschicktanz Jan 12, 2022

Uh oh!

jschicktanz Jan 12, 2022

Uh oh!

jschicktanz Jan 12, 2022

Uh oh!

jschicktanz Jan 12, 2022

Uh oh!

jschicktanz Jan 12, 2022

Uh oh!

jschicktanz Jan 12, 2022

Uh oh!

jschicktanz Jan 12, 2022

Uh oh!

jschicktanz Jan 12, 2022

Uh oh!

jschicktanz Jan 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	RunSpecs(t, "Resources Test Suite")
	RunSpecs(t, "Component Archive Set Test Suite")

	var _ = Describe("Set", func() {
	var _ = Describe("Get", func() {

	// CTFPaths is the path to the directory containing the ctf archive.
	// CTFPaths is the list of paths to the directories containing the ctf archives.

	Short: "Pushes all archives of a ctf to a remote repository",
	Short: "Pushes one or more ctf archives to a remote repository",

	Push pushes all component archives and oci artifacts to the defined oci repository.
	Push pushes one or more ctf archives (including all component archives and oci artifacts) to a remote repository.

ocm command and some ctf cmd extension #59

Are you sure you want to change the base?

ocm command and some ctf cmd extension #59

Uh oh!

Conversation

mandelsoft commented Dec 17, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants