-
Notifications
You must be signed in to change notification settings - Fork 42
improve ssh
command to work with not joined node
#138
Conversation
6bdfe6d
to
c1800b7
Compare
ssh
command to work with not joined node
c1800b7
to
bb5ec8b
Compare
bb5ec8b
to
3899e60
Compare
3899e60
to
b4eda29
Compare
b4eda29
to
ba7891e
Compare
ba7891e
to
1479bf2
Compare
Would be also nice if we could reflect the ip address behind the node name in the |
@DockToFuture this is possible only for machines that have the respective
|
@vpnachev We never talked about the ip as an argument, we just want to print it to ease debugging. |
1479bf2
to
62023fa
Compare
Sure, but let it be only for |
62023fa
to
06157d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
We discussed this suggestion with @DockToFuture and decided to not implement it for now, because there is no good approach for implementation. |
What this PR does / why we need it:
This PR fixes 2 issues:
Start Instance
requireszone-id
if we wantautomation. The same
zone-id
is required foraliyun ecs StopInstance
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
@vpnachev @ialidzhikov @DockToFuture
Release note: