Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

[target server] Fix home directory issue #182

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Conversation

petersutter
Copy link
Contributor

What this PR does / why we need it:
Patching the kubeConfig path in case it contains the ~ (tilde) sign should be done before checking if the file exists, otherwise the check fails

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

`target server` now also works when the `kubeConfig` path of the garden configuration contains the `~` (tilde) sign

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 2, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 2, 2020
Copy link
Contributor

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@DockToFuture DockToFuture merged commit a6814a0 into master Apr 2, 2020
@DockToFuture DockToFuture deleted the bug/fix-home-path branch April 2, 2020 16:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants