This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
gardenctl logs tf fix #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
DockToFuture
suggested changes
Apr 9, 2020
README.md
Outdated
| `gardenctl logs api | scheduler | controller-manager | etcd-main -c etcd |etcd-main -c backup-restore | vpn-seed | vpn-shoot | machine-controller-manager | prometheus |grafana | alertmanager | cluster-autoscaler` | ||
| - Show logs from garden nodes | ||
| `gardenctl target -g garden-name` | ||
| `gardenctl logs gardener-apiserver | gardener-controller-manager` |
| break | ||
| } | ||
|
|
||
| var prefixName string = (args[02]) |
There was a problem hiding this comment.
can we also check if shoot name exists and please use args[2]?
There was a problem hiding this comment.
for my understanding, so far the logic for logs tf will fetch all podName and podNamespace from a seed node, then match infra.tf from List output to found the pod name.
It takes about at least 11M List output data when I testing, depends on the total of shoots host in the seed node.
To check shoot name whether exists, it maybe double the times for the result output. search shoot name from List output ->exist -> search infra.tf from List output to found the pod name. Let me know any concerns. thanks
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add:
gardenctl logsreadmefix:
gardenctl logs tf infraresult output nulladd:
gardenctl logs tf infra shoot-nameresult output display only from shoot cluster instead of all shoot clustersWhich issue(s) this PR fixes:
Fixes #183
Special notes for your reviewer:
Release note: