Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Remove AWS instance profile from bastion nodes #218

Merged

Conversation

mvladev
Copy link

@mvladev mvladev commented Jul 9, 2020

What this PR does / why we need it:

AWS IAM Instance Profiles are not needed for bastions as they should be used only to jump to the broken instances.
See AWS EC2 RunInstances API.

Which issue(s) this PR fixes:
Fixes # n/a

Special notes for your reviewer:

Related issue gardener/gardener-extension-provider-aws#4

Release note:

AWS Bastion nodes no longer have any instance profiles associated with them.

AWS IAM Instance Profiles are not needed for bastions as they should be
used only to jump to the broken instances.
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 9, 2020
Copy link
Contributor

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Jul 13, 2020
@DockToFuture DockToFuture merged commit 47775dd into gardener-attic:master Jul 13, 2020
@mvladev mvladev deleted the remove-aws-instance-profile branch July 13, 2020 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants