Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

fix alicloud sshkey inaccessible due to missing a / #378

Merged
merged 2 commits into from
Oct 13, 2020
Merged

fix alicloud sshkey inaccessible due to missing a / #378

merged 2 commits into from
Oct 13, 2020

Conversation

neo-liang-sap
Copy link
Contributor

What this PR does / why we need it:
fix alicloud sshkey inaccessible due to missing a /
Which issue(s) this PR fixes:
Fixes #372

Special notes for your reviewer:

Release note:

fix alicloud sshkey inaccessible due to missing a /

@neo-liang-sap neo-liang-sap requested a review from a team as a code owner October 12, 2020 03:16
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 12, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 12, 2020
@neo-liang-sap neo-liang-sap mentioned this pull request Oct 13, 2020
Merged
@gardener-robot gardener-robot removed the needs/review Needs review label Oct 13, 2020
petersutter
petersutter suggested changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use filepath.Join as it is already done here e.g. https://github.com/gardener/gardenctl/blob/master/pkg/cmd/ssh_aws.go#L82

@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Oct 13, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 13, 2020
@neo-liang-sap
Copy link
Contributor Author

thanks @petersutter , i've commited the changes

@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 13, 2020
petersutter
petersutter approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging needs/changes Needs (more) changes and removed needs/changes Needs (more) changes reviewed/lgtm Has approval for merging labels Oct 13, 2020
@neo-liang-sap neo-liang-sap merged commit 2258705 into gardener-attic:master Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dansible dansible dansible approved these changes

@petersutter petersutter petersutter approved these changes

Assignees
No one assigned
Labels
needs/changes Needs (more) changes needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

alicloud ssh key not accessible
6 participants
@neo-liang-sap @petersutter @dansible @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot