Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

fix several gardenctl ssh aws issue #467

Merged

Conversation

neo-liang-sap
Copy link
Contributor

@neo-liang-sap neo-liang-sap commented Nov 25, 2020

What this PR does / why we need it:
fix several gardenctl ssh aws issue:

  • if we get VPC from host, there might be several VPCs but we didn't check it, hence changing to get vpc from subnet
  • there might be a list of images, use the first one
  • there's some issue in golang native check network function net.DialTimeout (at least in my testing), sometimes the timeout value passed doesn't take effect, the DialTimeout function will fail immediately , hence add time.Sleep to force wait 10s to retry

Which issue(s) this PR fixes:
Fixes #466

Special notes for your reviewer:

thanks for @mandelsoft @DockToFuture catching this, @dansible FYI

Release note:

fix several gardenctl ssh aws issue:
- if we get VPC from host, there might be several VPC but we didn't check it, hence changing to get vpc from subnet
- there might be a list of images, use the first one
- there's some issue in golang native check network function `net.DialTimeout` (at least in my testing), sometimes the `timeout` value passed doesn't take effect, the DialTimeout function will fail immediately , hence add time.Sleep to force wait 10s to retry

@neo-liang-sap neo-liang-sap requested a review from a team as a code owner November 25, 2020 16:44
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 25, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 25, 2020
@dansible
Copy link
Contributor

I'm getting this error when testing against gctl-aws:

(1/4) Fetching data from target shoot cluster
2020/11/25 12:01:16 AWS CLI failed with
An error occurred (AuthFailure) when calling the DescribeSubnets operation: AWS was not able to validate the provided access credentials

exit status 254
exit status 1

@dansible
Copy link
Contributor

NVM - i had some AWS environment variables set that caused the above issue for me.

This is working for me 👍

@gardener-robot gardener-robot removed the needs/review Needs review label Nov 25, 2020
@dansible dansible mentioned this pull request Nov 25, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 1, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 1, 2020
@neo-liang-sap
Copy link
Contributor Author

rebase according to latest master branch, tested as follows
image

@neo-liang-sap neo-liang-sap merged commit 8eb15cb into gardener-attic:master Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

several issues in gardenctl ssh aws_node
5 participants