Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Gactl cluster #504

Merged
merged 3 commits into from
May 14, 2021
Merged

Gactl cluster #504

merged 3 commits into from
May 14, 2021

Conversation

jguipi
Copy link
Contributor

@jguipi jguipi commented Feb 25, 2021

What this PR does / why we need it:
Update gardener cluster template

Which issue(s) this PR fixes:
Fixes none

Special notes for your reviewer:

  • none
    Release note:
Update gardener cluster template

@jguipi jguipi requested a review from a team as a code owner February 25, 2021 19:46
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 25, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 25, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 25, 2021
@neo-liang-sap
Copy link
Contributor

@jguipi - this PR is regarding testing shoots right? do we still need this ? i mean if we need it i will proceed with merge, or close if we don't need it any more

@jguipi
Copy link
Contributor Author

jguipi commented May 14, 2021

@jguipi - this PR is regarding testing shoots right? do we still need this ? i mean if we need it i will proceed with merge, or close if we don't need it any more

I'm not sure if we still need it, we were using those cluster for gardener testing. I think we can still merge it and keep gardener template up to date for future use.

@neo-liang-sap
Copy link
Contributor

proceed with merging per disucssion

@neo-liang-sap neo-liang-sap merged commit 09f086b into master May 14, 2021
@petersutter petersutter deleted the gactl-cluster branch December 2, 2021 12:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants