-
Notifications
You must be signed in to change notification settings - Fork 42
Change the way the gardenctl displays logs from loki #509
Change the way the gardenctl displays logs from loki #509
Conversation
9c80b36
to
62df71b
Compare
62df71b
to
18a8188
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good.
just one comment, I am not clear the docker id in there. Is that represent history Pod? eg. api-server has been restarted, the DockerID to distinguish previous Pod and current live Pod? if Yes, is it possible to display the Pod name to identify it as well ?
============================================================================================
Container Name: kube-controller-manager, DockerID: dbcb643a5dfbbd12e8dbf50e497dab8
=============================================================================================
// logs
// logs
// logs
=============================================================================================
Container Name: kube-controller-manager, DockerID: fsdfsdgsfsgsfsfsfs
=============================================================================================```
Yes correct. In each container there is a running docker process. DockerID represents this process. If the DockerID is changed, it means that the the container has been restarted.
Yes, it is possible will do this today |
18a8188
to
721524b
Compare
did the changes |
Аlso to emphasise that the current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Per discussion with @Kristian-ZH i will merge this PR and trigger a minor release |
What this PR does / why we need it:
Change the default value of
tail
flag from 200 to 1000, because if someone does not know about this flag, he will think that there is an issue with gardenctl logs/loki because very few logs are displayedChange the way the gardenctl displays logs from loki.
Now the logs will be visualised in the following way:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: