Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

Make node network optional #49

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Make node network optional #49

merged 1 commit into from
Oct 28, 2019

Conversation

rfranzke
Copy link
Contributor

What this PR does / why we need it:
Make the node network optional as not every environment/provider has the requirement to forward traffic between the seed and the shoot node network via VPN. Some providers only have one large network for all VMs, hence, here the seed workers and all shoot workers can see themselves and talk with each other always.

Special notes for your reviewer:
/cc @stoyanr @marin

Release note:

It is now possible to omit the `NODE_NETWORK` environment variable for both `vpn-seed` and `vpn-shoot` in case it is not required to tunnel traffic from the seed to the shoot node network via the VPN.

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 23, 2019
@zanetworker
Copy link
Contributor

zanetworker commented Oct 23, 2019 •
edited
Loading

/lgtm

can you please rebase, also let's wait till @DockToFuture is back to have another look.

@rfranzke rfranzke force-pushed the feature/node-network-optional branch from 2114bf2 to a828823 Compare October 24, 2019 09:07
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 24, 2019
@rfranzke
Copy link
Contributor Author

rebase done

@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 24, 2019
@rfranzke rfranzke force-pushed the feature/node-network-optional branch from a828823 to 93e398a Compare October 28, 2019 08:22
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 28, 2019
DockToFuture
DockToFuture approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zanetworker zanetworker merged commit 70923b7 into master Oct 28, 2019
@rfranzke rfranzke deleted the feature/node-network-optional branch October 28, 2019 18:33
@rfranzke rfranzke mentioned this pull request Nov 1, 2019
Closed
@rfranzke rfranzke mentioned this pull request Jan 7, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DockToFuture DockToFuture DockToFuture approved these changes

@marwinski marwinski Awaiting requested review from marwinski

@zanetworker zanetworker Awaiting requested review from zanetworker

Assignees

@zanetworker zanetworker

@DockToFuture DockToFuture

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rfranzke @zanetworker @DockToFuture @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3