Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete orphaned routes for nodes whose deletion was missed #1

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Delete orphaned routes for nodes whose deletion was missed #1

merged 1 commit into from
Sep 13, 2022

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
If the AWS custom route controller is not running when a node is been deleted, its route for the pod CIDR may become orphaned with status "blackholed". This can become a problem if the pod CIDR is reused for another node.
With this fix, such orphaned routes are deleted.

Additionally the golang build image version was upgraded from v1.18.5 to v1.19.1.

Release note:

Delete orphaned routes for nodes whose deletion was missed.

@MartinWeindel MartinWeindel requested a review from a team as a code owner September 13, 2022 10:36
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 13, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 13, 2022
ScheererJ
ScheererJ approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 13, 2022
@MartinWeindel MartinWeindel merged commit 0ef53e4 into main Sep 13, 2022
@MartinWeindel MartinWeindel deleted the fix/orphaned-routes branch September 13, 2022 12:02
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinWeindel @ScheererJ @gardener-robot-ci-1 @gardener-robot