Create events on route updates failures and don't keep node routes to main route table #8
Conversation
gardener-robot
added
needs/review
ghost
added
the
reviewed/ok-to-test
|
/invite @ScheererJ @DockToFuture @axel7born |
ghost
added
needs/ok-to-test
MartinWeindel
force-pushed
the
events-on-update
branch
from
41fc737 to
a869359
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
pkg/updater/routes.go
Outdated
| for _, route := range table.Routes { | ||
| if route.NatGatewayId != nil && aws.StringValue(route.DestinationCidrBlock) == "0.0.0.0/0" { | ||
| // all subnet route tables have a NAT gateway route |
There was a problem hiding this comment.
Not sure if it makes sense to make the inverse check of looking at IGW instead of the NAT GWs. Would it make any sense in BYO-VPC cases where there may be other route tables ?
There was a problem hiding this comment.
You are right. Checking of IGW now in main route table.
There was a problem hiding this comment.
Is it always required to have an internet gateway? Would it be possible to do it differently in a bring-your-own scenario, e.g. via vpc peering?
There was a problem hiding this comment.
Currently this is checked at runtime: https://github.com/gardener/gardener-extension-provider-aws/blob/907425e071477b973e56f319c43786a43ede67af/pkg/controller/infrastructure/configvalidator.go#L119 especially for BYO scenario
There was a problem hiding this comment.
I have simplified the main table recognition by using the name tag.
What do you think? @ScheererJ @kon-angelo
gardener-robot
added
reviewed/lgtm
MartinWeindel
force-pushed
the
events-on-update
branch
from
a869359 to
ecf73d1
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
ghost
removed
the
reviewed/ok-to-test
MartinWeindel
force-pushed
the
events-on-update
branch
from
ecf73d1 to
9406165
Compare
ghost
added
reviewed/ok-to-test
gardener-robot
added
the
status/closed
5 participants
What this PR does / why we need it:
Events are now created in the
kube-systemnamespace on route updates, especially if they are failing.Note, that on normal operation the event is created only once.
If the route update has errors, the event is created everytime. As soon as it recovers an event for normal operation is created one time.
These events will be analysed by a health check of the provider-aws extension.
Additionally, the main table will not contain the routes to the worker nodes anymore. It is sufficient to have them in the route tables for the subnets. If the VPC is used by multiple clusters, keeping the routes in the main table would cause quota issues (
RouteLimitExceeded) just sooner. There is a hard limit of 1000 routes per route table according to the AWS documentation, see Amazon VPC quotasWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: