Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup and improve dev #1172

Merged
merged 2 commits into from
Feb 27, 2025
Merged

cleanup and improve dev #1172

merged 2 commits into from
Feb 27, 2025

Conversation

ccwienk
Copy link
Member

@ccwienk ccwienk commented Feb 26, 2025

Release note:

- cleanup (now) unused module oci.kaniko
- let install-gha-libs action install also gardener-oci and gardener-ocm packages from cc-util's head

@ccwienk
cleanup: rm (now) unused oci.kaniko-module
f7828e0
@ccwienk
build ocm and oci packages from head
9961ac2 
Make development/testing easier, and change install-gha-libs action to
also build oci and ocm packages from head.
@gardener-robot gardener-robot added the needs/review Needs review label Feb 26, 2025
@gardener-robot gardener-robot added the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Feb 26, 2025
zkdev
zkdev approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@zkdev zkdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 27, 2025
8R0WNI3
8R0WNI3 approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@8R0WNI3 8R0WNI3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ccwienk ccwienk merged commit 948800d into master Feb 27, 2025
14 checks passed
@ccwienk ccwienk deleted the cleanup-and-improve-dev branch February 27, 2025 11:50
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkdev zkdev zkdev approved these changes

@8R0WNI3 8R0WNI3 8R0WNI3 approved these changes

@TuanAnh17N TuanAnh17N Awaiting requested review from TuanAnh17N TuanAnh17N is a code owner

Assignees
No one assigned
Labels
reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ccwienk @zkdev @8R0WNI3 @gardener-robot