Fix FindIssuerKeyByName (binding per-loop bug) #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot
added
the
status/closed
|
@MartinWeindel Does it make sense to write a unit test for this case? |
|
@BeckerMax That's a good point. I have added it to my backlog. |
|
Tests added with PR #116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes a bug in the method FindIssuerKeyByName caused by the "binding per-loop" instead of "binding per-iteration" of for loops in Go.
As a consequence of this bug, a seemingly random issuer was selected if there have been multiple issuers.
Which issue(s) this PR fixes:
Fixes #113
Special notes for your reviewer:
Release note: