Certificates without common name (simplified certificates for domain names longer than 64 chars) #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-2
added
the
reviewed/ok-to-test
|
/hold waiting for support in go-acme/lego dependency. See PR go-acme/lego#2054 |
gardener-robot-ci-2
added
needs/ok-to-test
gardener-robot
added
the
reviewed/do-not-merge
MartinWeindel
force-pushed
the
drop-63-letter-restriction
branch
from
771623f
to
288779f
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
MartinWeindel
force-pushed
the
drop-63-letter-restriction
branch
from
288779f
to
4a1e014
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot-ci-3
added
the
reviewed/ok-to-test
|
/unhold updated to go-acme/lego v4.15.0 |
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Let's encrypt will support certificates without common name starting at 2023-11-29. Details see in this announcement. It allows to create certificates for domains longer than 64 characters without needing to set the common name to a shorter domain name.
This PR allows to create certificates without a common name. For source resources with annotations the first domain name is only used as common name if it is shorter or equal than 64 chars.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: