Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Challenge using DNSRecord resources #177

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Challenge using DNSRecord resources #177

merged 3 commits into from
Jun 6, 2024

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented May 7, 2024 •
edited
Loading

What this PR does / why we need it:
This PR allows to use dnsrecords.extensions.gardener.cloud instead of dnsentries.dns.gardener.cloud for creating DNS TXT records of DNS challenges on requesting certificates.
Certificate or source resources need two additional annotations cert.gardener.cloud/dnsrecord-provider-type and cert.gardener.cloud/dnsrecord-secret-ref to specify provider type and secret reference needed for the DNSRecord specification.

Which issue(s) this PR fixes:
Fixes #173

Special notes for your reviewer:
Depends on gardener/gardener#9714

Release note:

Use `dnsrecords.extensions.gardener.cloud` API as an alternative to `dnsentries.dns.gardener.cloud` for DNS challenges.

@MartinWeindel MartinWeindel requested a review from a team as a code owner May 7, 2024 13:14
@gardener-robot gardener-robot added needs/review Needs review size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs/second-opinion Needs second review by someone else labels May 7, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 7, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 7, 2024
@MartinWeindel MartinWeindel added the area/ipcei IPCEI (Important Project of Common European Interest) label May 8, 2024
@MartinWeindel MartinWeindel force-pushed the challenge-with-dnsrecords branch from dbd725b to b597c5a Compare May 27, 2024 14:39
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 27, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 27, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 4, 2024
@MartinWeindel MartinWeindel merged commit 83d421f into master Jun 6, 2024
7 checks passed
@MartinWeindel MartinWeindel deleted the challenge-with-dnsrecords branch June 6, 2024 08:22
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use dnsrecords.extensions.gardener.cloud API
5 participants
@MartinWeindel @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot