-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring: introduce issuer key interface to simplify rewrite #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
do-not-merge/needs-kind
Indicates a PR lacks a `kind/foo` label and requires one.
cla: yes
Indicates the PR's author has signed the cla-assistant.io CLA.
labels
Aug 6, 2024
gardener-prow
bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Aug 6, 2024
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 6, 2024
gardener-robot-ci-1
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 6, 2024
MartinWeindel
force-pushed
the
issuer-key-interface
branch
from
August 6, 2024 14:03
f9615fc
to
c0001f2
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 6, 2024
MartinWeindel
force-pushed
the
issuer-key-interface
branch
from
August 6, 2024 14:05
c0001f2
to
a32b2d7
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 6, 2024
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 6, 2024
RaphaelVogel
approved these changes
Aug 6, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RaphaelVogel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 9c6bfdb4a3f855816ec6ec7463a1d99a53d17b37
|
gardener-prow
bot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Aug 6, 2024
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 6, 2024
/kind task |
gardener-prow
bot
added
kind/task
General task
and removed
do-not-merge/needs-kind
Indicates a PR lacks a `kind/foo` label and requires one.
labels
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cla: yes
Indicates the PR's author has signed the cla-assistant.io CLA.
kind/task
General task
lgtm
Indicates that a PR is ready to be merged.
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Refactoring: introduce issuer key interface to simplify rewrite without controller-manager-library.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: