Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istio gateways: Allow to specify namespace for TLS secret #316

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
Istio expects the TLS secret in the namespace of the ingress-gateway POD.
If a Gateway resource should be stored in a different namespace, the managed TLS secret will be created in the same namespace. With the added annotation cert.gardener.cloud/secret-namespace, it is possible to specify a different namespace. This annotation is only available for Istio Gateway resources and Services of type LoadBalancer.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Istio gateways: Allow to specify namespace for TLS secret by annotation `cert.gardener.cloud/secret-namespace`.

Copy link

gardener-prow bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from martinweindel. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Oct 18, 2024
@gardener-prow gardener-prow bot requested a review from RaphaelVogel October 18, 2024 12:36
@gardener-prow gardener-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 18, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 18, 2024
@MartinWeindel MartinWeindel merged commit 23ece9a into master Oct 18, 2024
9 of 10 checks passed
@MartinWeindel MartinWeindel deleted the enh/secret-namespace-for-istio branch October 18, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants