make propagation timeout configurable and use it for DNSEntry TTL #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinWeindel
added
area/robustness
gardener-robot-ci-1
added
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
On Alicloud DNS the DNS record with the DNS challenge is not propagated with the current fixed TTL setting of 30s.
With TTL of 60s it is propagated correctly to public DNS servers.
With this PR, the TTL is set to the propagation timeout of the DNS challenge.
This propagation timeout defaults to 60s.
Additionally it can set with the command line option
--propagation-timeout.Which issue(s) this PR fixes:
Fixes #32
Special notes for your reviewer:
Release note: