cleanup orphan outdated certificate secrets #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
MartinWeindel
force-pushed
the
gc-cert-secrets
branch
from
2a07b47
to
049218c
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
MartinWeindel
force-pushed
the
gc-cert-secrets
branch
from
049218c
to
9031cad
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
mandelsoft
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The secret referenced by a certificate custom resource is not deleted if the certificate CR is deleted,
because it is unclear if the certificate will be recreated, e.g if the source object has been disappeared temporarily.
With this PR a garbage collection is added which deletes a certificate secret if it is not referenced by a certificate CR and it is outdated at least for 14 days. The garbage collection runs on startup and every 7 days.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: