common name annotation for services and ingresses #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
reviewed/ok-to-test
gardener-robot-ci-2
added
reviewed/ok-to-test
MartinWeindel
force-pushed
the
commonname-annotation
branch
from
9d71e99
to
b1997c9
Compare
gardener-robot
added
size/M
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
mandelsoft
reviewed
Nov 17, 2020
| annotatedDomains := []string{} | ||
| if cn != "" { | ||
| annotatedDomains = append(annotatedDomains, cn) | ||
| } | ||
| for _, e := range strings.Split(a, ",") { |
There was a problem hiding this comment.
I think we already had a function like this to parse lists in strings in the CMLib.
There was a problem hiding this comment.
Yes, there is a function, but it produces a StringSet. The order should be kept here.
| if e != "" && e != cn { | ||
| domains = append(domains, e) | ||
| } | ||
| } |
| } | ||
| result := []string{cn} | ||
| for _, host := range hosts { | ||
| if host != cn { |
There was a problem hiding this comment.
Is is required to exclude the cn from the hosts?
There was a problem hiding this comment.
It is excluded to avoid adding it twice.
mandelsoft
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allow to specify the common name for certificates of services and ingresses explicitly by using an annotation
cert.gardener.cloud/commonname.Which issue(s) this PR fixes:
Fixes #48
Special notes for your reviewer:
Release note: