Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renew certificate if its certificate secret is invalid/corrupt instead of going to state error #54

Merged
merged 1 commit into from
Nov 26, 2020
Merged

renew certificate if its certificate secret is invalid/corrupt instead of going to state error #54

merged 1 commit into from
Nov 26, 2020

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
This is a fix for a corner case. If a certificate was successfully requested and later the secret data is deleted or corrupt,
the certificate object went to state error, as the validity of the secret could not be checked.
E.g. status of the certificate shows:

status:
  message: fetching tls.crt from request secret failed
  state: Error

With this change, the invalid secret data is ignored and processed as if it needs to be renewed.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

renew certificate if its certificate secret is invalid/corrupt instead of going to state error

@MartinWeindel MartinWeindel requested a review from a team as a code owner November 26, 2020 09:44
@gardener-robot gardener-robot added needs/review Needs review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 26, 2020
@MartinWeindel
Copy link
Member Author

/invite @timuthy

@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 26, 2020
timuthy
timuthy approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thank you very much @MartinWeindel !

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 26, 2020
@MartinWeindel MartinWeindel merged commit 99c389a into master Nov 26, 2020
@MartinWeindel MartinWeindel deleted the ignore-invalid-secret branch November 26, 2020 09:58
@MartinWeindel MartinWeindel mentioned this pull request Nov 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timuthy timuthy timuthy approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MartinWeindel @timuthy @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot