Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel dialogs on @keydown:esc #1933

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

holgerkoser
Copy link
Member

@holgerkoser holgerkoser commented Jun 21, 2024

What this PR does / why we need it:
Cancel dialogs on @keydown:esc

Which issue(s) this PR fixes:
Fixes #1792

Special notes for your reviewer:

Release note:


@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 21, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 21, 2024
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 21, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 21, 2024
@holgerkoser holgerkoser merged commit 006f052 into master Jun 24, 2024
8 checks passed
@holgerkoser holgerkoser deleted the enh/cancel-dialog-on-esc branch June 24, 2024 08:04
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 24, 2024
holgerkoser added a commit that referenced this pull request Jun 25, 2024
holgerkoser added a commit that referenced this pull request Jun 26, 2024
holgerkoser added a commit that referenced this pull request Jun 26, 2024
* master: (169 commits)
  revert #1933 (#1937)
  Migrate GProjectDialog to script setup (#1934)
  Update connect-kubectl.md
  cancel on esc (#1933)
  fix project menu after vuetify update (#1929)
  Update dependency vuetify to v3.6.10 (#1927)
  Bump braces from 3.0.2 to 3.0.3 (#1922)
  Update dependency vite to v5.3.1 (#1920)
  Update dependency @braintree/sanitize-url to v7.0.3 (#1925)
  Update dependency vue to v3.4.29 (#1921)
  Update dependency jose to v5.4.1 (#1924)
  Update dependency sass to v1.77.6 (#1917)
  Update dependency vuetify to v3.6.9 (#1916)
  Update dependency @vueuse/router to v10.11.0 (#1914)
  Update dependency @vueuse/integrations to v10.11.0 (#1913)
  Update actions/checkout action to v4.1.7 (#1918)
  Update dependency @vueuse/core to v10.11.0 (#1912)
  Adapt the debug and test scripts for `vscode-jest-runner` to be compatible with Vitest. (#1923)
  Update dependency vue-router to v4.3.3 (#1907)
  Update Yarn to v4.3.0 (#1910)
  ...

# Conflicts:
#	.pnp.cjs
#	backend/lib/app.js
#	backend/lib/config/gardener.js
#	backend/lib/security/index.js
#	backend/lib/services/shoots.js
#	frontend/package.json
#	frontend/vite.config.js
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing escape key does not close certain modal dialogs
5 participants