Revert changes from PR 1933 #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-2
added
reviewed/ok-to-test
* master: Migrate GProjectDialog to script setup (#1934) # Conflicts: # frontend/src/components/dialogs/GProjectDialog.vue
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
holgerkoser
added a commit
that referenced
this pull request
Jun 26, 2024
* master: (169 commits) revert #1933 (#1937) Migrate GProjectDialog to script setup (#1934) Update connect-kubectl.md cancel on esc (#1933) fix project menu after vuetify update (#1929) Update dependency vuetify to v3.6.10 (#1927) Bump braces from 3.0.2 to 3.0.3 (#1922) Update dependency vite to v5.3.1 (#1920) Update dependency @braintree/sanitize-url to v7.0.3 (#1925) Update dependency vue to v3.4.29 (#1921) Update dependency jose to v5.4.1 (#1924) Update dependency sass to v1.77.6 (#1917) Update dependency vuetify to v3.6.9 (#1916) Update dependency @vueuse/router to v10.11.0 (#1914) Update dependency @vueuse/integrations to v10.11.0 (#1913) Update actions/checkout action to v4.1.7 (#1918) Update dependency @vueuse/core to v10.11.0 (#1912) Adapt the debug and test scripts for `vscode-jest-runner` to be compatible with Vitest. (#1923) Update dependency vue-router to v4.3.3 (#1907) Update Yarn to v4.3.0 (#1910) ... # Conflicts: # .pnp.cjs # backend/lib/app.js # backend/lib/config/gardener.js # backend/lib/security/index.js # backend/lib/services/shoots.js # frontend/package.json # frontend/vite.config.js # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Dialogs are also closed if the user presses ESC for a select box. Revert the change!
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: