Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control Plane Tweaking #36

Closed
8 tasks
vlerenc opened this issue Mar 7, 2018 · 7 comments · Fixed by #462
Closed
8 tasks

Control Plane Tweaking #36

vlerenc opened this issue Mar 7, 2018 · 7 comments · Fixed by #462
Assignees
Labels
component/dashboard Gardener Dashboard kind/enhancement Enhancement, improvement, extension

Comments

@vlerenc
Copy link
Member

vlerenc commented Mar 7, 2018

Story

  • As user I want to tweak certain features like alpha/beta switches or allowing privileged containers or not, so that I can do more things with my clusters, even though not all are production-ready yet in Kubernetes.

Motivation

The Gardener allows to tweak the configurations of API server, controller manager, scheduler and kube-proxy as well as allowing privileged containers or not, but we haven't exposed that yet (unless we are fine with #34).

Acceptance Criteria

To be defined in more detail. We need to investigate first (with Rafael F.), whether we can offer some pre-selection or how to actually allow the configuration (outcome can also be to leave it at #34, but then we need some documentation and it will not be very convenient).

  • During cluster creation/update the user shall be able to switch on/off privileged containers support
  • ...

Resources

See Gardener.

Definition of Done

  • Knowledge is distributed: Have you spread your knowledge in pair programming/code review?
  • Unit Tests are provided: Have you written automated unit tests or added manual test tickets?
  • Integration Tests are provided: Have you written automated integration tests or added manual test tickets?
  • Minimum API exposure: If you have added public API, was it really necessary/is it minimal?
  • Operations guide: Have you updated the operations guide about ops-relevant changes?
  • User documentation: Have you informed the documentation developers about user-relevant changes?
@vlerenc vlerenc added the kind/enhancement Enhancement, improvement, extension label Mar 7, 2018
@vlerenc vlerenc added component/dashboard Gardener Dashboard and removed component/dashboard Gardener Dashboard labels Jun 27, 2018
@vlerenc vlerenc added the lifecycle/icebox Temporarily on hold (will not age; may have dependencies, lack priority, miss feedback, etc.) label Aug 5, 2018
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Oct 5, 2018
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Dec 5, 2018
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Feb 4, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Apr 6, 2019
@vlerenc
Copy link
Member Author

vlerenc commented Apr 10, 2019

Are #208 and #302 replacing this one? If so, let's close this one (or the other one).

@grolu
Copy link
Contributor

grolu commented Apr 10, 2019

I don't know... Yes I guess we can close this one if we do not plan to offer anything besides the yaml editor.

@vlerenc
Copy link
Member Author

vlerenc commented Apr 10, 2019

Not sure what your plans are in regards to the cluster creation dialog?

@grolu
Copy link
Contributor

grolu commented Apr 10, 2019

currently not planned to implement in the UI @vlerenc do you think that we should invest here?

@vlerenc
Copy link
Member Author

vlerenc commented Apr 10, 2019

Well, people don't know what is possible. We can also strive for a pragmatic approach. I believe, there were issues with context-sensitive help in the yaml editor and even if not, it would not be obvious where to look/check. One colleague proposed to start off with something like the Gardener examples manifests when you switch during cluster creation to the yaml editor. Then users would see the options. That would definitely help. WDYT?

@grolu
Copy link
Contributor

grolu commented Apr 10, 2019

We could start by providing at least a link to the examples. Moreover, we already planned to support to export the configuration on the create cluster dialog into an URL. We could encode the yaml into the URL and this way it would be possible to provide Create Cluster links with templates for different purposes.

@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jun 10, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Aug 10, 2019
@grolu grolu self-assigned this Sep 2, 2019
@grolu
Copy link
Contributor

grolu commented Sep 25, 2019

We now support code completion in the cluster YAML editor. Do we agree that this helps people to figure out what can be configured and that we can close this issue?
see PR #462

@ghost ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Nov 25, 2019
@ghost ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jan 25, 2020
@ghost ghost removed the lifecycle/icebox Temporarily on hold (will not age; may have dependencies, lack priority, miss feedback, etc.) label Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dashboard Gardener Dashboard kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants