Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YAML Editor enhancements #462

Merged
merged 52 commits into from
Mar 25, 2020
Merged

YAML Editor enhancements #462

merged 52 commits into from
Mar 25, 2020

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Sep 25, 2019 •
edited
Loading

What this PR does / why we need it:
Introduces Code Completion and Tooltips in Shoot Editor.

Which issue(s) this PR fixes:
Fixes #36 Fixes #419

Special notes for your reviewer:
Screen Shot 2019-09-25 at 12 22 34
Screen Shot 2019-09-25 at 12 22 27
Screen Shot 2019-09-25 at 12 22 06

Release note:

The dashboard now supports code completion and shows information about keywords in the cluster YAML editor

@grolu grolu added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Sep 25, 2019
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 25, 2019
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 25, 2019
@grolu grolu mentioned this pull request Sep 25, 2019
Closed
8 tasks
@grolu grolu changed the title [Do not merge] Create cluster enhancements [Do not merge] Create cluster and YAML Editor enhancements Sep 25, 2019
@grolu grolu changed the title [Do not merge] Create cluster and YAML Editor enhancements [Do not merge] YAML Editor enhancements Sep 25, 2019
@grolu
Merge branch 'master' into create_cluster_enhancements
8bed82c 
# Conflicts:
#	.secrets.baseline
#	frontend/src/components/ShootEditor.vue
#	frontend/src/pages/NewShoot.vue
#	frontend/src/pages/NewShootEditor.vue
#	frontend/src/pages/ShootDetailsEditor.vue
#	frontend/src/store/index.js
#	frontend/src/store/modules/shoots.js
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 27, 2019
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 27, 2019
@grolu
Merge branch 'master' into create_cluster_enhancements
1d1cee5 
# Conflicts:
#	backend/package-lock.json
#	backend/package.json
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 8, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 8, 2019
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 8, 2019
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 2, 2019
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 2, 2019
@grolu @holgerkoser
Update frontend/src/utils/shootEditorCompletions.js
d46bb04 
Co-Authored-By: Holger Koser <holger.koser@sap.com>
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 20, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 20, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 20, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 20, 2020
holgerkoser
holgerkoser approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one test will fail. If you fix that it lgtm.

@petersutter petersutter self-requested a review March 20, 2020 14:05
petersutter
petersutter approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the latest comments:
there is still one minor bug for an edge case where the completion fails but we this can be fixed in a separate pr:
ctrl + space to autocomplete a string, press enter and then again, press ctrl + space and enter. The key will change from e.g. test to tetest.

but in general: lgtm

@grolu @petersutter
Update frontend/src/components/ShootEditor.vue
537d743 
Co-Authored-By: Peter Sutter <peter.sutter@sap.com>
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 20, 2020
@grolu @holgerkoser
Update frontend/src/components/ShootEditor.vue
8bde6c6 
Co-Authored-By: Holger Koser <holger.koser@sap.com>
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 20, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 20, 2020
@grolu
Copy link
Contributor Author

grolu commented Mar 20, 2020

apart from the latest comments:
there is still one minor bug for an edge case where the completion fails but we this can be fixed in a separate pr:
ctrl + space to autocomplete a string, press enter and then again, press ctrl + space and enter. The key will change from e.g. test to tetest.

but in general: lgtm

Ok I will look into this

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 20, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 20, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 20, 2020
@grolu
Copy link
Contributor Author

grolu commented Mar 23, 2020

Ok I will look into this

@petersutter can you give feedback if the latest changes resolve your issue?

@petersutter
Copy link
Member

yes it's solved

@grolu grolu merged commit af49bcf into master Mar 25, 2020
@petersutter petersutter deleted the create_cluster_enhancements branch March 25, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@petersutter petersutter petersutter approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify OIDC configuration on Shoot creation/update Control Plane Tweaking
6 participants
@grolu @petersutter @holgerkoser @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3