Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]UI support to manage labels/taints/annotations on workerpool #390

Closed
PadmaB opened this issue May 18, 2019 · 2 comments · Fixed by #416
Closed

[Feature]UI support to manage labels/taints/annotations on workerpool #390

PadmaB opened this issue May 18, 2019 · 2 comments · Fixed by #416
Assignees
@grolu
Labels
area/usability Usability related component/dashboard Gardener Dashboard effort/2w Effort for issue is around 2 weeks exp/intermediate Issue that requires some project experience kind/enhancement Enhancement, improvement, extension

Comments

@PadmaB
Copy link

PadmaB commented May 18, 2019

Workerpool now supports labels/taints/annotations which is then propagated to actual nodes via MCM. Kindly refer the example Shoot yaml for details

For now, the user has to directly edit the Shoot yaml in the dashboard. However, it will be convenient to have UI support to manage labels/taints/annotations on the workerpool with ease
@PadmaB PadmaB added component/dashboard Gardener Dashboard kind/enhancement Enhancement, improvement, extension labels May 18, 2019
@grolu grolu added area/usability Usability related exp/intermediate Issue that requires some project experience size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/accepted Issue was accepted as something we need to work on labels May 20, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jul 19, 2019
@grolu
Copy link
Contributor

grolu commented Aug 6, 2019

Also, consider adding the other missing options: https://github.com/gardener/gardener/blob/master/example/90-shoot-aws.yaml

@grolu grolu self-assigned this Aug 6, 2019
@grolu
Copy link
Contributor

grolu commented Aug 8, 2019

I discussed this with @vlerenc. We will not support editing taints, labels, annotations for now as it is an expert feature that does not need to be exposed via the UI.
However, I added support for configuring Worker Image as well as Max. Surge

@grolu grolu mentioned this issue Aug 8, 2019
Merged
@gardener-robot-ci-1 gardener-robot-ci-1 removed the status/accepted Issue was accepted as something we need to work on label Aug 24, 2019
@gardener-robot gardener-robot added effort/2w Effort for issue is around 2 weeks and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grolu grolu

Labels
area/usability Usability related component/dashboard Gardener Dashboard effort/2w Effort for issue is around 2 weeks exp/intermediate Issue that requires some project experience kind/enhancement Enhancement, improvement, extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor create shoot gardener/dashboard
4 participants
@PadmaB @gardener-robot-ci-1 @grolu @gardener-robot