-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor create shoot #416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # frontend/src/components/HibernationScheduleEvent.vue # frontend/src/pages/ShootItemEditor.vue # frontend/src/router/index.js
…tween create cluster components
# Conflicts: # .secrets.baseline
# Conflicts: # .secrets.baseline # frontend/src/dialogs/CreateClusterDialog.vue
removed unused files
# Conflicts: # frontend/src/dialogs/CreateClusterDialog.vue
added infrastructure name as text reordered create cluster cards some cleanup
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 20, 2019
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 20, 2019
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 20, 2019
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 21, 2019
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 22, 2019
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 22, 2019
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 23, 2019
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 23, 2019
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 23, 2019
grolu
removed
the
reviewed/do-not-merge
Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies
label
Aug 23, 2019
holgerkoser
approved these changes
Aug 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR replaces the Create Cluster Popup with a dedicated create cluster page. The user can now switch between UI and yaml mode when creating clusters (using the same UI paradigm as on the cluster details page). This solves several issues by allowing the user to configure the shoot resource before creating the cluster (which is required for some things, e.g. dns settings)
Which issue(s) this PR fixes:
Fixes #208 Fixes #340 Fixes #302 Fixes #23 Fixes #432 Fixes #390 Fixes #415 Fixes #435 Fixes #318
Special notes for your reviewer:
Release note: