Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cluster delete button in garden namespace #415

Closed
petersutter opened this issue Jun 24, 2019 · 3 comments · Fixed by #416
Closed

Disable cluster delete button in garden namespace #415

petersutter opened this issue Jun 24, 2019 · 3 comments · Fixed by #416
Assignees
Labels
area/security Security related area/usability Usability related component/dashboard Gardener Dashboard effort/1d Effort for issue is around 1 day exp/beginner Issue that requires only basic skills kind/enhancement Enhancement, improvement, extension

Comments

@petersutter
Copy link
Member

The garden namespace is only accessible to operators. However, to prevent any deletions by mistake of shoots in this reserved namespace the delete button should be disabled.
Optionally introduce a config flag to enable/disable this behaviour of the UI

@mvladev
Copy link

mvladev commented Jun 24, 2019

garden namespace is not special. I could name it garden-system or something similar and install my components there.

@petersutter
Copy link
Member Author

petersutter commented Jun 24, 2019

currently we have several places in the dashboard where the garden namespace is hardcoded. In addition, even the gardener itself has a GardenNamespace constant.
Currently we live with this assumption until there is a need to make it more dynamic, but then also gardener has to adapt.

@grolu
Copy link
Contributor

grolu commented Jun 25, 2019

We discussed that we could (instead of hardcoding Garden namespace) also disable critical actions (e.g. delete hibernate, etc.) for clusters with purpose INFRA

@grolu grolu added area/security Security related area/usability Usability related component/dashboard Gardener Dashboard exp/beginner Issue that requires only basic skills kind/enhancement Enhancement, improvement, extension size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 25, 2019
@grolu grolu self-assigned this Aug 12, 2019
@gardener-robot gardener-robot added effort/1d Effort for issue is around 1 day and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security Security related area/usability Usability related component/dashboard Gardener Dashboard effort/1d Effort for issue is around 1 day exp/beginner Issue that requires only basic skills kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants