Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor create shoot #416

Merged
merged 64 commits into from
Aug 23, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
64045b6
[WIP]
grolu Apr 15, 2019
d277be7
Merge branch 'master' into refactor_create_shoot
grolu Apr 16, 2019
047d24c
[WIP] Improved shoot resource updates between ui/yaml view
grolu Apr 18, 2019
f1ef3ca
[WIP] switched to dedicated bus for communicating user interaction be…
grolu Apr 26, 2019
b50498b
Merge branch 'master' into refactor_create_shoot
grolu Apr 26, 2019
8660094
[WIP] Remove confirm navigation prompt when switching between yaml an…
grolu Apr 29, 2019
762a9b1
[WIP]
grolu Apr 30, 2019
5d0e79c
[WIP] Fixed maintenance auto update handling
grolu May 3, 2019
47d8a71
[WIP] fixed name check
grolu May 7, 2019
0c16f23
Merge branch 'master' into refactor_create_shoot
grolu May 7, 2019
dcd7159
[WIP] Support regions without seed
grolu May 7, 2019
4feabdd
Merge branch 'master' into refactor_create_shoot
grolu May 20, 2019
278e585
Merge branch 'master' into refactor_create_shoot
grolu May 22, 2019
3466748
[WIP]
grolu May 22, 2019
946896d
[WIP] Choose infrastructure card
grolu May 22, 2019
3fadfb2
[WIP] Option to add secrets on create cluster page
grolu May 22, 2019
072cfa9
[WIP]
grolu May 23, 2019
b632ddf
[WIP] Fixed some validation issues
grolu May 24, 2019
804bf5a
Do not save via keyboard shortcuts if editor is in create mode
grolu Jun 4, 2019
c6d75c9
Merge branch 'master' into refactor_create_shoot
grolu Jun 4, 2019
7ccef72
Fixed some warnings
grolu Jun 6, 2019
9f7e97d
removed old create cluster dialog leftovers
grolu Jun 6, 2019
d5b430c
removed unused components
grolu Jun 6, 2019
b845be4
Added create cluster button to create shoot editor page
grolu Jun 7, 2019
ed08197
Removed accidentally checked in fakeprofile
grolu Jun 7, 2019
701e196
Merge branch 'master' into refactor_create_shoot
grolu Jun 25, 2019
6fcf601
Merge branch 'master' into refactor_create_shoot
grolu Jun 25, 2019
75c7c29
Show confirm dialog when leaving create cluster page
grolu Jun 25, 2019
12b0bd2
Merge branch 'master' into refactor_create_shoot
grolu Jul 2, 2019
7899d1a
Configure purpose on create cluster details page
grolu Jul 2, 2019
66fb588
Manage Addons on Cluster Details
grolu Jul 4, 2019
46b66e5
Merge branch 'master' into refactor_create_shoot
grolu Jul 4, 2019
668cb06
Removed addons card from shoot details
grolu Jul 12, 2019
12d6085
Merge branch 'master' into refactor_create_shoot
grolu Jul 24, 2019
cd1d2f6
Fixed Bug: Worker name conflict (yaml edited), delete one cluster, cr…
grolu Jul 24, 2019
b313c4d
Show Create Cluster Editor edit warning
grolu Jul 26, 2019
7c9ee60
Support different machine / volume types per zone in worker managemen…
grolu Jul 30, 2019
5db215e
Fixed layout and navigation confirmation issue in editor
grolu Jul 30, 2019
0bcf91c
Refactored ConfirmDialog to be promise based
grolu Aug 5, 2019
3a7ebe3
Show shoot zone on cluster details page
grolu Aug 5, 2019
831f2be
Implemented support for configuring machine image and max. surge for …
grolu Aug 8, 2019
038e987
Merge branch 'master' into refactor_create_shoot
grolu Aug 8, 2019
13fedfd
Opt out os updates
grolu Aug 8, 2019
8cafe8d
Moved common shootItem getters to mixin
grolu Aug 12, 2019
9b44dbe
Disable actions for clusters with purpose "infrastrcuture"
grolu Aug 12, 2019
937b119
row wrap on create cluster page
grolu Aug 13, 2019
f5f2cf5
Disable kubernetes dashboard by default
grolu Aug 13, 2019
b6cacca
Component Cleanup #318
grolu Aug 14, 2019
eb99e13
Changes as discussed
grolu Aug 14, 2019
8644134
fixed some remove button layout issues
grolu Aug 14, 2019
a8b38dd
Renamed ConfirmDialog to GDialog
grolu Aug 14, 2019
0c439f7
Improved Dialog code
grolu Aug 15, 2019
3e7aaf8
Fix maintenance components reset
grolu Aug 15, 2019
eb61ded
changes as discussed
grolu Aug 19, 2019
a6c3763
Generate default shoot resource in store
grolu Aug 20, 2019
d62485d
optimized machineAndVolumeTypePredicate function
grolu Aug 20, 2019
76c0782
changes as discussed
grolu Aug 20, 2019
1fd6c16
Merge branch 'master' into refactor_create_shoot
grolu Aug 20, 2019
fe4530f
Fixed shoot addon chips
grolu Aug 21, 2019
77908e4
Refactored ShootItemEditor to make into separate pages and one re-use…
grolu Aug 22, 2019
13d70af
renamed shoot route
grolu Aug 22, 2019
eff0187
Fixed secret link
grolu Aug 23, 2019
38dc194
Some renaming
grolu Aug 23, 2019
2e0f53f
small ui changes
grolu Aug 23, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 85 additions & 15 deletions .secrets.baseline
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"exclude": {
"files": "^.secrets.baseline$",
"files": "^.secrets.baseline$|^.secrets.baseline_temp$",
"lines": null
},
"generated_at": "2019-07-02T10:37:07Z",
"generated_at": "2019-08-23T13:59:56Z",
"plugins_used": [
{
"name": "AWSKeyDetector"
Expand Down Expand Up @@ -34,7 +34,7 @@
{
"hashed_secret": "0b4049b5e5a601cb07835c4b4b6881a9a609387c",
"is_secret": false,
"line_number": 49,
"line_number": 48,
"type": "Secret Keyword"
}
],
Expand All @@ -60,7 +60,15 @@
{
"hashed_secret": "959d73abdef41e5d0f4ec2afd98cb68d37953a2a",
"is_secret": false,
"line_number": 22,
"line_number": 21,
"type": "Secret Keyword"
}
],
"backend/lib/github/octokit.js": [
{
"hashed_secret": "e5e9fa1ba31ecd1ae84f75caaa474f3a663f05f4",
"is_secret": false,
"line_number": 56,
"type": "Secret Keyword"
}
],
Expand All @@ -76,13 +84,13 @@
{
"hashed_secret": "7ea6be9eecb6605329a1b1870c2fd2af9b896991",
"is_secret": false,
"line_number": 42,
"line_number": 43,
"type": "Secret Keyword"
},
{
"hashed_secret": "8b142a91cfb6e617618ad437cedf74a6745f8926",
"is_secret": false,
"line_number": 79,
"line_number": 93,
"type": "Secret Keyword"
}
],
Expand Down Expand Up @@ -112,35 +120,35 @@
{
"hashed_secret": "30118aa1aa8a06fa5365743b3a5db69fc62b9760",
"is_secret": false,
"line_number": 270,
"line_number": 263,
"type": "Secret Keyword"
}
],
"backend/test/acceptance/api.infrastructureSecrets.spec.js": [
{
"hashed_secret": "e9fe51f94eadabf54dbf2fbbd57188b9abee436e",
"is_secret": false,
"line_number": 37,
"line_number": 35,
"type": "Secret Keyword"
}
],
"backend/test/acceptance/api.shoots.spec.js": [
{
"hashed_secret": "f7e3bc894e61a47eb1810807767610a3c88527c3",
"is_secret": false,
"line_number": 118,
"line_number": 116,
"type": "Secret Keyword"
},
{
"hashed_secret": "ccbee52710eb8a59dad640c207009ad01fc76b35",
"is_secret": false,
"line_number": 120,
"line_number": 118,
"type": "Secret Keyword"
},
{
"hashed_secret": "0ac5df4b0f96ad426c76dd945dfcef01e25c8818",
"is_secret": false,
"line_number": 122,
"line_number": 120,
"type": "Secret Keyword"
}
],
Expand Down Expand Up @@ -208,21 +216,21 @@
{
"hashed_secret": "fb3c6e4de85bd9eae26fdc63e75f10a7f39e850e",
"is_secret": false,
"line_number": 52,
"line_number": 50,
"type": "Secret Keyword"
},
{
"hashed_secret": "8843d7f92416211de9ebb963ff4ce28125932878",
"is_secret": false,
"line_number": 79,
"line_number": 77,
"type": "Secret Keyword"
}
],
"charts/identity/templates/configmap.yaml": [
{
"hashed_secret": "09343c85545555efc31e6e70b7ea7dcadf854930",
"is_secret": false,
"line_number": 42,
"line_number": 43,
"type": "Secret Keyword"
}
],
Expand All @@ -246,6 +254,52 @@
"type": "Private Key"
}
],
"frontend/src/components/NewShoot/NewShootDetails.vue": [
{
"hashed_secret": "d5d4cd07616a542891b7ec2d0257b3a24b69856e",
"is_secret": false,
"line_number": 121,
"type": "Secret Keyword"
},
{
"hashed_secret": "e5e9fa1ba31ecd1ae84f75caaa474f3a663f05f4",
"is_secret": false,
"line_number": 191,
"type": "Secret Keyword"
}
],
"frontend/src/components/NewShoot/NewShootInfrastructureDetails.vue": [
{
"hashed_secret": "2c0580ffd7d80319531cf629f5e90f747b1386f1",
"is_secret": false,
"line_number": 193,
"type": "Secret Keyword"
},
{
"hashed_secret": "b8c6d8c49add25b398e5beeaae12689ee2bd10b6",
"is_secret": false,
"line_number": 386,
"type": "Secret Keyword"
},
{
"hashed_secret": "e5e9fa1ba31ecd1ae84f75caaa474f3a663f05f4",
"is_secret": false,
"line_number": 396,
"type": "Secret Keyword"
},
{
"hashed_secret": "22f6a1953ff02167cbfecf24ea856d94bc397254",
"is_secret": false,
"line_number": 412,
"type": "Secret Keyword"
},
{
"hashed_secret": "bd66a10f34934a079686639a5b287d8dad8d1c4c",
"is_secret": false,
"line_number": 414,
"type": "Secret Keyword"
}
],
"frontend/src/components/Secret.vue": [
{
"hashed_secret": "e8cdc05b346aa0d4a91a2bf6d7c6a0941a6555a7",
Expand Down Expand Up @@ -376,11 +430,27 @@
"type": "Secret Keyword"
}
],
"frontend/src/dialogs/SecretDialogWrapper.vue": [
{
"hashed_secret": "32f64badcf839f19bfd0b409f9c49ead291fba63",
"is_secret": false,
"line_number": 31,
"type": "Secret Keyword"
}
],
"frontend/src/pages/NewShoot.vue": [
{
"hashed_secret": "cb780a6106d2b3106ec569f878d3068415696acd",
"is_secret": false,
"line_number": 285,
"type": "Secret Keyword"
}
],
"frontend/src/pages/Secrets.vue": [
{
"hashed_secret": "32f64badcf839f19bfd0b409f9c49ead291fba63",
"is_secret": false,
"line_number": 148,
"line_number": 134,
"type": "Secret Keyword"
}
]
Expand Down
7 changes: 1 addition & 6 deletions backend/lib/middleware.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,9 @@ const _ = require('lodash')
const config = require('./config')
const logger = require('./logger')
const { NotFound, InternalServerError } = require('./errors')
const { customAddonDefinitions } = require('./services')

async function frontendConfig (req, res, next) {
const user = req.user
function frontendConfig (req, res, next) {
const frontendConfig = {}
try {
frontendConfig.customAddonDefinitions = await customAddonDefinitions.list({ user, namespace: 'garden' })
} catch (err) { /* ignore error */ }
res.json(Object.assign(frontendConfig, config.frontend))
}

Expand Down
13 changes: 13 additions & 0 deletions backend/lib/routes/shoots.js
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,19 @@ router.route('/:name/spec/hibernation/schedules')
}
})

router.route('/:name/spec/addons')
.put(async (req, res, next) => {
try {
const user = req.user
const namespace = req.params.namespace
const name = req.params.name
const body = req.body
res.send(await shoots.replaceAddons({ user, namespace, name, body }))
} catch (err) {
next(err)
}
})

router.route('/:name/spec/cloud/:infrastructureKind/workers')
.put(async (req, res, next) => {
try {
Expand Down
41 changes: 0 additions & 41 deletions backend/lib/services/customAddonDefinitions.js

This file was deleted.

3 changes: 1 addition & 2 deletions backend/lib/services/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,5 @@ module.exports = {
members: require('./members'),
authorization: require('./authorization'),
authentication: require('./authentication'),
journals: require('./journals'),
customAddonDefinitions: require('./customAddonDefinitions')
journals: require('./journals')
}
15 changes: 13 additions & 2 deletions backend/lib/services/shoots.js
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,16 @@ exports.replaceHibernationSchedules = async function ({ user, namespace, name, b
return patch({ user, namespace, name, body: payload })
}

exports.replaceAddons = async function ({ user, namespace, name, body }) {
const addons = body
const payload = {
spec: {
addons
}
}
return patch({ user, namespace, name, body: payload })
}

exports.replaceWorkers = async function ({ user, namespace, infrastructureKind, name, body }) {
const workers = body
const patchOperations = [
Expand All @@ -155,7 +165,7 @@ exports.replaceWorkers = async function ({ user, namespace, infrastructureKind,
}

exports.replaceMaintenance = async function ({ user, namespace, name, body }) {
const { timeWindowBegin, timeWindowEnd, updateKubernetesVersion } = body
const { timeWindowBegin, timeWindowEnd, updateKubernetesVersion, updateOSVersion } = body
const payload = {
spec: {
maintenance: {
Expand All @@ -164,7 +174,8 @@ exports.replaceMaintenance = async function ({ user, namespace, name, body }) {
end: timeWindowEnd
},
autoUpdate: {
kubernetesVersion: updateKubernetesVersion
kubernetesVersion: updateKubernetesVersion,
machineImageVersion: updateOSVersion
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions backend/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading