Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Cleanup #318

Closed
grolu opened this issue Mar 4, 2019 · 1 comment · Fixed by #416
Closed

Component Cleanup #318

grolu opened this issue Mar 4, 2019 · 1 comment · Fixed by #416
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related component/dashboard Gardener Dashboard effort/2d Effort for issue is around 2 days exp/beginner Issue that requires only basic skills kind/cleanup Something that is not needed anymore and can be cleaned up

Comments

@grolu
Copy link
Contributor

grolu commented Mar 4, 2019

With an increasing number of Vue components and no common naming guidelines, it gets hard to keep an overview of the frontend components. We should introduce folders (groups) to bundle similar components. Moreover, it would be a good idea to rename some components to have similar naming for similar components. Another task is to refactor the remaining sections without dedicated component of the ShootItemCards page into components.

@grolu grolu added exp/beginner Issue that requires only basic skills area/quality Output qualification (tests, checks, scans, automation in general, etc.) related component/dashboard Gardener Dashboard kind/cleanup Something that is not needed anymore and can be cleaned up size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Mar 4, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels May 4, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jul 4, 2019
grolu added a commit that referenced this issue Aug 20, 2019
grolu added a commit that referenced this issue Aug 23, 2019
* [WIP]

* [WIP] Improved shoot resource updates between ui/yaml view

* [WIP] switched to dedicated bus for communicating user interaction between create cluster components

* [WIP] Remove confirm navigation prompt when switching between yaml and ui mode

* [WIP]

* [WIP] Fixed maintenance auto update handling

* [WIP] fixed name check

* [WIP] Support regions without seed
removed unused files

* [WIP]

* [WIP] Choose infrastructure card

* [WIP] Option to add secrets on create cluster page

* [WIP]
Select created secret after dialog close
Fixed some issues when switching from yaml to create ui (due to new select infrastructure card)

* [WIP] Fixed some validation issues

* Do not save via keyboard shortcuts if editor is in create mode

* Fixed some warnings

* removed old create cluster dialog leftovers

* removed unused components
added infrastructure name as text
reordered create cluster cards
some cleanup

* Added create cluster button to create shoot editor page

* Removed accidentally checked in fakeprofile

* Show confirm dialog when leaving create cluster page

* Configure purpose on create cluster details page

* Manage Addons on Cluster Details
Removed "custom addons" - now that we have extensions, this is no longer required

* Removed addons card from shoot details
Show enabled addons in one line as part of shoot details card

* Fixed Bug: Worker name conflict (yaml edited), delete one cluster, create still disabled
Fixed Bug: Do not show navigation popup when create clicked
Show navigation popup only if user changed something
Show warning popup when navigating to yaml editor while cluster data is invalid

* Show Create Cluster Editor edit warning
Display errors (Create Cluster Yaml editor)

* Support different machine / volume types per zone in worker management #428

* Fixed layout and navigation confirmation issue in editor

* Refactored ConfirmDialog to be promise based

* Show shoot zone on cluster details page

* Implemented support for configuring machine image and max. surge for worker groups

* Opt out os updates

* Moved common shootItem getters to mixin

* Disable actions for clusters with purpose "infrastrcuture"

* row wrap on create cluster page

* Disable kubernetes dashboard by default

* Component Cleanup #318

* Changes as discussed

* fixed some remove button layout issues

* Renamed ConfirmDialog to GDialog
Created ConfirmDialog Component which is based on GDialog for simplified usage

* Improved Dialog code

* Fix maintenance components reset

* changes as discussed

* Generate default shoot resource in store
Moved set defaults logic from components to store

* optimized machineAndVolumeTypePredicate function

* changes as discussed

* Fixed shoot addon chips

* Refactored ShootItemEditor to make into separate pages and one re-use component

* renamed shoot route

* Fixed secret link

* Some renaming

* small ui changes
@grolu grolu closed this as completed Sep 2, 2019
@grolu
Copy link
Contributor Author

grolu commented Sep 2, 2019

closed via #416

@gardener-robot gardener-robot added effort/2d Effort for issue is around 2 days and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related component/dashboard Gardener Dashboard effort/2d Effort for issue is around 2 days exp/beginner Issue that requires only basic skills kind/cleanup Something that is not needed anymore and can be cleaned up
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants