No operator action required issues #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Hide user issues filter to hide no operator action required issues
gardener-robot
added
needs/review
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
petersutter
reviewed
Jun 22, 2021
Comment on lines
145
to
147
| if (temporaryError) { | ||
| return 'mdi-clock-alert' | ||
| } |
There was a problem hiding this comment.
do you think we really need an own icon for temporary errors?
There was a problem hiding this comment.
I don't know. I thought has we highlight errors with known error codes, this could improve the ability to find out what is going on with your clusters faster. We can discuss this. As we also use this icon as an indication for cluster expiration it could irritate some users.
There was a problem hiding this comment.
I added a screenshot that shows the icon
There was a problem hiding this comment.
I removed the dedicated icon
petersutter
reviewed
Jun 22, 2021
|
Thanks, idea wise it looks good to me. |
gardener-robot-ci-1
added
reviewed/ok-to-test
Co-authored-by: Peter Sutter <peter.sutter@sap.com>
gardener-robot-ci-3
added
reviewed/ok-to-test
holgerkoser
reviewed
Jun 24, 2021
holgerkoser
reviewed
Jun 24, 2021
| color="error" | ||
| :icon="userError ? 'mdi-account-alert' : 'mdi-alert'" | ||
| :icon="icon(userError, temporaryError)" | ||
| :prominent="!!userError ? true : false" |
holgerkoser
reviewed
Jun 24, 2021
holgerkoser
reviewed
Jun 24, 2021
holgerkoser
reviewed
Jun 24, 2021
holgerkoser
reviewed
Jun 24, 2021
Comment on lines
36
to
39
| <div v-for="({ shortDescription, userError, temporaryError }) in tooltip.errorCodeObjects" :key="shortDescription"> | ||
| <v-icon v-if="userError" class="mr-1" color="white" small>mdi-account-alert</v-icon> | ||
| <v-icon v-else-if="temporaryError" class="mr-1" color="white" small>mdi-clock-alert</v-icon> | ||
| <v-icon v-else class="mr-1" color="white" small>mdi-alert</v-icon> |
There was a problem hiding this comment.
Only the icon name is different. Why not a method like above?
Co-authored-by: Holger Koser <holger.koser@sap.com>
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
holgerkoser
reviewed
Jun 24, 2021
holgerkoser
reviewed
Jun 24, 2021
| @@ -138,13 +138,10 @@ export default { | |||
| } | |||
| }, | |||
| methods: { | |||
| icon (userError, temporaryError) { | |||
| icon ({ userError, temporaryError }) { | |||
There was a problem hiding this comment.
If we want to keep this method remove the unused temporaryError
gardener-robot-ci-3
added
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for the new
ERR_INFRA_REQUEST_THROTTLINGerror code.Furthermore the option to hide user issues for operators has been replaced by an option to remove both user issues and temporary issues.
Which issue(s) this PR fixes:
Fixes #1031 Fixes #1046
Special notes for your reviewer:
@vpnachev Please let me know if this change makes sense from your point of view.
Release note: