Hetzner support #1043
Hetzner support #1043
Conversation
|
@poelzi Thank you for your contribution. |
gardener-robot
added
needs/review
|
Thank you @poelzi for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
|
@holgerkoser, @grolu You have pull request review open invite, please check |
|
Hi @poelzi, By merging your request we take over ownership and responsibility for your code, therefore the headers have to be adapted. Thank you |
|
@grolu You have pull request review open invite, please check |
| @@ -120,6 +120,9 @@ export default { | |||
| return findFreeNetworks(this.currentZonesNetworkConfiguration, this.existingWorkerCIDR, this.cloudProviderKind, this.allZones.length) | |||
| }, | |||
| availableZones () { | |||
| if (!this.zonedCluster) { | |||
There was a problem hiding this comment.
One last question before we merge your PR: Why did you add this code here? While I don't think that it will cause any problem with other infrastructures, I'm curious why you added it in the first place. I briefly tested your implementation and for me it worked without errors even without this code (at least not on the create cluster screen). Did you experience an error when changing an existing worker or did you just add this to be on the safe side?
There was a problem hiding this comment.
Because the hetzner provider implemenation was first without zones and the frontend assumes zones so i fixed some issues in this regard. We later switched to zones and the fixes became obsolete. I think they are still useful so I let them in this PR.
There was a problem hiding this comment.
Just for clarification: When did the issue occur? After shoot creation on the configure workers popup? Or somewhere else?
There was a problem hiding this comment.
When creating a now shoot, it complained about missing zones even the api returned no zones. I added the zonedCluster to return false in hcloud case and with this fix the problem was gone.
gardener-robot
added
reviewed/lgtm
petersutter
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
the
needs/ok-to-test
What this PR does / why we need it:
This PR adds support for the hetzner provider extension
Special notes for your reviewer:
hcloud provider extension
hcloud machine controller
Release note:
* Support for the hetzner cloud extension (hcloud)