Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix-1.52] Support search for gardener error codes #1137

Merged
merged 1 commit into from
Nov 30, 2021
Merged

[hotfix-1.52] Support search for gardener error codes #1137

merged 1 commit into from
Nov 30, 2021

Conversation

holgerkoser
Copy link
Member

@holgerkoser holgerkoser commented Nov 30, 2021 •
edited by petersutter
Loading

What this PR does / why we need it:
Support gardener error codes in the cluster search field. Below some examples are listed:

  • ERR_INFRA_UNAUTHORIZED
  • ERR_INFRA_INSUFFICIENT_PRIVILEGES
  • ERR_INFRA_QUOTA_EXCEEDED
  • ERR_INFRA_DEPENDENCIES
  • ERR_CLEANUP_CLUSTER_RESOURCES
  • ERR_INFRA_RESOURCES_DEPLETED
  • ERR_CONFIGURATION_PROBLEM
  • ERR_RETRYABLE_CONFIGURATION_PROBLEM
  • ERR_INFRA_RATE_LIMITS_EXCEEDED
  • ERR_RETRYABLE_INFRA_DEPENDENCIES
  • ...

Which issue(s) this PR fixes:
Fixes #1136

Special notes for your reviewer:

Release note:

 Support gardener error codes in the cluster search field

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 30, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 30, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 30, 2021
petersutter
petersutter approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 30, 2021
@holgerkoser holgerkoser merged commit 1c6df04 into hotfix-1.52 Nov 30, 2021
@holgerkoser holgerkoser deleted the hotfix/issue-1136 branch November 30, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersutter petersutter petersutter approved these changes

@grolu grolu Awaiting requested review from grolu

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@holgerkoser @petersutter @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot